Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vulture for static analysis #1655

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Adding vulture for static analysis #1655

merged 3 commits into from
Oct 28, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Oct 27, 2021

Removing dead code found previously by vulture in local runs.

Removing dead code found previously by vulture in local runs.
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #1655 (5b10559) into master (2017786) will increase coverage by 0.49%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1655      +/-   ##
==========================================
+ Coverage   88.99%   89.48%   +0.49%     
==========================================
  Files          52       57       +5     
  Lines       10119    10728     +609     
==========================================
+ Hits         9005     9600     +595     
- Misses       1114     1128      +14     
Impacted Files Coverage Δ
redis/connection.py 71.74% <ø> (-0.04%) ⬇️
tasks.py 0.00% <0.00%> (ø)
whitelist.py 0.00% <0.00%> (ø)
redis/commands/helpers.py 76.00% <0.00%> (-10.67%) ⬇️
redis/commands/redismodules.py 77.77% <0.00%> (-1.17%) ⬇️
redis/commands/json/__init__.py 100.00% <0.00%> (ø)
redis/commands/timeseries/commands.py 99.49% <0.00%> (ø)
redis/commands/timeseries/info.py 94.28% <0.00%> (ø)
tests/test_timeseries.py 100.00% <0.00%> (ø)
redis/commands/timeseries/utils.py 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2017786...5b10559. Read the comment docs.

@chayim chayim merged commit 8178997 into redis:master Oct 28, 2021
@chayim chayim deleted the ck-vulture branch October 28, 2021 09:46
barshaul pushed a commit to barshaul/redis-py that referenced this pull request Nov 3, 2021
* Adding vulture for static analysis

Removing dead code found previously by vulture in local runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants