Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding reserve as an alias for create, so that we have BF.RESERVE and CF.RESERVE accuratenly supported #2331

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Aug 11, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@chayim chayim added the feature New feature label Aug 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Merging #2331 (0f1f38f) into master (2cea637) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2331      +/-   ##
==========================================
- Coverage   92.21%   92.17%   -0.04%     
==========================================
  Files         111      111              
  Lines       28751    28796      +45     
==========================================
+ Hits        26513    26544      +31     
- Misses       2238     2252      +14     
Impacted Files Coverage Δ
redis/commands/bf/commands.py 98.39% <100.00%> (+0.01%) ⬆️
tests/test_bloom.py 99.62% <100.00%> (+0.01%) ⬆️
tests/conftest.py 84.94% <0.00%> (-0.78%) ⬇️
tests/test_asyncio/test_cluster.py 97.08% <0.00%> (-0.34%) ⬇️
tests/test_asyncio/test_search.py 98.43% <0.00%> (-0.32%) ⬇️
tests/test_cluster.py 96.85% <0.00%> (-0.24%) ⬇️
redis/asyncio/connection.py 86.00% <0.00%> (-0.12%) ⬇️
redis/connection.py 86.90% <0.00%> (ø)
tests/test_connection_pool.py 100.00% <0.00%> (ø)
tests/test_asyncio/test_timeseries.py 100.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dvora-h dvora-h changed the title Adding reserve as an alias for create, so that we have BF.RESERVE accuratenly supported Adding reserve as an alias for create, so that we have BF.RESERVE and CF.RESERVE accuratenly supported Aug 29, 2022
@dvora-h dvora-h merged commit a6d473b into redis:master Aug 29, 2022
dvora-h added a commit that referenced this pull request Nov 21, 2022
… CF.RESERVE accuratenly supported (#2331)

* Adding reserve as an alias for create, so that we have BF.RESERVE accuratenly supported

* add reserve to cf commands

Co-authored-by: dvora-h <[email protected]>
@chayim chayim deleted the ck-aliasreserve branch March 26, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants