Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3086

Closed
wants to merge 1 commit into from
Closed

Update README.md #3086

wants to merge 1 commit into from

Conversation

earthgecko
Copy link
Contributor

Related to #3085

Pull Request check-list

Please make sure to review and check all of these items:

  • [N/A] Do tests and lints pass with this change?
  • [N/A] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • [ x] Is the new or changed code fully tested? Yes in Preview mode.
  • [x ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • [ N/A] Is there an example added to the examples folder (if applicable)?
  • [No] Was the change added to CHANGES file?

Description of change

Related to #3085

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6a4b49) 91.17% compared to head (d876bd9) 91.16%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3086      +/-   ##
==========================================
- Coverage   91.17%   91.16%   -0.01%     
==========================================
  Files         127      127              
  Lines       32855    32855              
==========================================
- Hits        29956    29953       -3     
- Misses       2899     2902       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@earthgecko
Copy link
Contributor Author

[no] Do tests and lints pass with this change?
[no] Do the CI tests pass with this change?

pyspelling is complaining about something I never added to the commit :) PRs are so much fun.

@dvora-h
Copy link
Collaborator

dvora-h commented Jan 9, 2024

I don't think this comment is necessary, as I explained here, to avoid this you can set the value of lib_name and lib_version to None

@dvora-h dvora-h closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants