Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tests for modules ACL and modules config changes in 8.0 #3489

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Adding tests for modules ACL and modules config changes in 8.0 #3489

merged 3 commits into from
Jan 30, 2025

Conversation

petyaslavova
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Adding unit tests that cover the module integration in Redis 8.0:

  • ACL configuration for modules and specific module commands
  • Module configuration manipulations through the CONFIG command

@petyaslavova petyaslavova force-pushed the add_acl_config_test_for_8_0_modules_changes branch from a5db734 to 9e3ef4b Compare January 29, 2025 08:56
@petyaslavova petyaslavova force-pushed the add_acl_config_test_for_8_0_modules_changes branch from 9e3ef4b to 20ad0f0 Compare January 29, 2025 09:09
vladvildanov
vladvildanov requested changes Jan 29, 2025
View reviewed changes
tests/test_asyncio/test_commands.py Outdated Show resolved Hide resolved
tests/test_asyncio/test_commands.py Outdated Show resolved Hide resolved
tests/test_asyncio/test_commands.py Outdated Show resolved Hide resolved
tests/test_asyncio/test_commands.py Outdated Show resolved Hide resolved
tests/test_asyncio/test_commands.py Outdated Show resolved Hide resolved
tests/test_asyncio/test_commands.py Show resolved Hide resolved
tests/test_asyncio/test_commands.py Outdated Show resolved Hide resolved
@vladvildanov vladvildanov added the maintenance Maintenance (CI, Releases, etc) label Jan 29, 2025
@vladvildanov vladvildanov merged commit ceb12fe into master Jan 30, 2025
39 checks passed
@vladvildanov vladvildanov deleted the add_acl_config_test_for_8_0_modules_changes branch January 30, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladvildanov vladvildanov vladvildanov approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petyaslavova @vladvildanov