Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oauth): reset rate limit earlier in refresh cycle #158

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

sigaloid
Copy link
Member

reset rate limit as soon as we encounter a low rate limit, rather than once we finish retrieving a new token

if this doesn't work, my next choice is a single thread owning write access to OAUTH_CLIENT that can receive a reset signal from anywhere, and keeps track of the rate limits to allow both the expiry event and the rate limit event to reset it, without causing concurrent token retrievals

@sigaloid sigaloid merged commit 023cc85 into main Jun 27, 2024
3 checks passed
@sigaloid sigaloid deleted the oauth_proper_atomics branch June 27, 2024 02:20
@sigaloid sigaloid restored the oauth_proper_atomics branch February 7, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant