Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly fix #40

Closed
wants to merge 1 commit into from
Closed

Nightly fix #40

wants to merge 1 commit into from

Conversation

onur
Copy link

@onur onur commented May 9, 2017

rusttype no longer builds with recent nightly: rustc 1.19.0-nightly (f1140a331 2017-05-08). IDK what caused this but this patch is fixing issue.

@onur
Copy link
Author

onur commented May 10, 2017

Relevant issue: rust-lang/rust#41849

Looks like this is a bug in rust compiler.

@dylanede
Copy link
Contributor

Sorry, I'm not merging this. If something builds on stable but not on nightly, then the rule of thumb is that nightly is at fault. The whole point of stable is so that you don't have to patch crates to keep up with nightly. This particular change in nightly looks like a regression, not a fix to a backwards incompatible bug, which would be the only (rare) case in which patching would make sense.

@dylanede dylanede closed this May 10, 2017
@onur
Copy link
Author

onur commented May 10, 2017

Thanks for the reply. It's ok.

I only posted this because people can use this workaround until nightly gets fixed if they really need to use rusttype and latest nightly. I accidentally found myself in this situation and I'd like to share my solution; [replace] section solved my issue until nightly gets fixed:

[replace."rusttype:0.2.1"]
git = "https://github.com/onur/rusttype.git"
rev = "2c0b58a4017c1387b0bb621def92541eba256381"

@jackpot51
Copy link
Member

I am requesting transfer to another maintainer, please read and comment here: https://github.com/dylanede/rusttype/issues/55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants