Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit Bigquery output to create jobs in a different project #2532

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Roviluca
Copy link

Bigquery allows to have 3 different projects involved when querying Bigquery:

  1. The project where the service account is created
  2. The project where the job is created
  3. The project where the data is stored.

The current implementation does not allow this flexibility.
if the project is set the job will be created in the Dataset's project, otherwise the client tries to use bigquery.DetectProjectID that returns the service account's project and searches the dataset in there.

With this PR I added the possibility to set JobProjectID so that users can have the flexibility to set the 3 parameters with different values.

@Roviluca Roviluca requested a review from Jeffail as a code owner April 19, 2024 18:04
@Roviluca Roviluca force-pushed the main branch 7 times, most recently from d9cc32b to d202b5b Compare April 19, 2024 18:18
@Roviluca
Copy link
Author

Hello @Jeffail does this PR make sense or do you prefer me do approach this in another way?

@garsir
Copy link

garsir commented Jun 7, 2024

Hey @Jeffail, is this something we can add to benthos? Currently benthos doesn't support a compute/storage project split that we are trying to enact in BQ.

dull feedback or comments appreciated

@oleksandr-kaleniuk
Copy link

Are there any updates on this? It's a very useful feature

@damjad
Copy link

damjad commented Aug 28, 2024

Hello,

Can anyone please work on this?

This is a handy feature we need for the widespread adoption of Redpanda Connect in our tech stack.
Currently, it blocks us from using any of the Redpanda offerings in prod.

@mihaitodor
Copy link
Collaborator

mihaitodor commented Aug 28, 2024

@damjad @Roviluca Thanks for your patience with this! I took a stab at rebasing the code. Would you mind testing it to make sure it still works as expected both with job_project empty and also with job_project set to some project?

@damjad
Copy link

damjad commented Aug 28, 2024

Thanks @mihaitodor!

We will test it on our side and keep you posted.

@damjad
Copy link

damjad commented Sep 5, 2024

Hello,

We have tested it manually at our end.

We have tested with both happy scenarios mentioned above and it's working as expected.
Moreover, we have tested with some negative scenarios and it also gives errors as expected.

Please feel free to merge it.

Copy link
Collaborator

@Jeffail Jeffail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Roviluca (and all the testers!)

@Jeffail Jeffail merged commit 4db3939 into redpanda-data:main Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants