-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permit Bigquery output to create jobs in a different project #2532
Conversation
d9cc32b
to
d202b5b
Compare
Hello @Jeffail does this PR make sense or do you prefer me do approach this in another way? |
Hey @Jeffail, is this something we can add to benthos? Currently benthos doesn't support a compute/storage project split that we are trying to enact in BQ. dull feedback or comments appreciated |
Are there any updates on this? It's a very useful feature |
Hello, Can anyone please work on this? This is a handy feature we need for the widespread adoption of Redpanda Connect in our tech stack. |
Signed-off-by: luca.rovi <[email protected]> Signed-off-by: luca.rovinetti <[email protected]>
Thanks @mihaitodor! We will test it on our side and keep you posted. |
Hello, We have tested it manually at our end. We have tested with both happy scenarios mentioned above and it's working as expected. Please feel free to merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Roviluca (and all the testers!)
Bigquery allows to have 3 different projects involved when querying Bigquery:
The current implementation does not allow this flexibility.
if the project is set the job will be created in the Dataset's project, otherwise the client tries to use
bigquery.DetectProjectID
that returns the service account's project and searches the dataset in there.With this PR I added the possibility to set JobProjectID so that users can have the flexibility to set the 3 parameters with different values.