chore(mapStateToProps): port to typescript #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-redux-docs ready! 🔨 Explore the source changes: 4137320 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/60de22779baea60007354dd4 😎 Browse the preview: https://deploy-preview-1745--react-redux-docs.netlify.app |
tony-go
changed the title
|
Why did |
markerikson
requested changes
Jun 29, 2021
timdorr
force-pushed
the
typescript-port-mapStateToProps
branch
from
366e3cd to
9c7ca0e
Compare
Looks like the lockfile on master was updated to v2, but not on the TS branch. I just fixed that up now. |
tony-go
force-pushed
the
typescript-port-mapStateToProps
branch
from
0fad9ff to
4137320
Compare
|
Not sure, but feel like I'm reaching something. Let me know @markerikson . |
|
Ought to be good for now. Thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks 👋
anythere. I have to make a second pass to add generics. But feel free to give me feedback anyway.This pull request follows the typescript migration initiative (#1737).
files to migrate:
mapStateToPropswrapMapToProps