Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has createSelector been removed in 0.5.0? #137

Closed
jrsinclair opened this issue Apr 30, 2019 · 6 comments
Closed

Has createSelector been removed in 0.5.0? #137

jrsinclair opened this issue Apr 30, 2019 · 6 comments

Comments

@jrsinclair
Copy link

After upgrading from 0.4.3 to 0.5.0 I can no longer import createSelector() from redux-starter-kit. It doesn't appear to be exported anywhere in index.ts either. Has it been removed? Do I need to install selectorator as a separate dependency now?

@markerikson
Copy link
Collaborator

markerikson commented Apr 30, 2019

Whoops! Looks like the export got accidentally removed in the process of converting the TS build process.

I'll see if I can re-add that tonight.

Just out of curiosity: are you using Selectorator's "string selector" feature at all, or just the basic Reselect-based functionality?

@jrsinclair
Copy link
Author

FWIW, we are using the string selector feature. It wouldn't be the end of the world if we had to switch (I read what you're thinking in #82), but I do find it convenient.

@markerikson
Copy link
Collaborator

Yeah, that's what I was thinking of. Thanks for the feedback!

@markerikson
Copy link
Collaborator

@jrsinclair : okay, just published 0.5.1, which I think should fix the issue. Can you try that and confirm?

For reference, this was caused by the changes in #128 .

@jrsinclair
Copy link
Author

Worked like a charm. Thanks. Really appreciate the quick response.

@markerikson
Copy link
Collaborator

Sure, sorry about that!

markerikson pushed a commit that referenced this issue Apr 20, 2021
* rename createPureApi to createBaseApi

Co-authored-by: Matt Sutkowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants