-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Usage with TypeScript" section to the docs #267
Conversation
Deploy preview for redux-starter-kit-docs ready! Built with commit 8afcecf https://deploy-preview-267--redux-starter-kit-docs.netlify.com |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8afcecf:
|
e093ae4
to
456eabb
Compare
On a sidenote, @markerikson - the generated netlify urls still say "redux-starter-kit" :D |
456eabb
to
bb70be0
Compare
bb70be0
to
0cdb478
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fairly good overall. Nitpicks are mostly grammar, casing, formatting.
@phryneas : yeah, I know :) that's because the actual Netlify site name is |
Format it with Prettier, that's causing the CI failures. |
Argh xD |
22d1f60
to
0b0f913
Compare
Okay, I think I got all your comments. Thanks for the thorough review! |
Great, thanks! Per my comment in #262 , can you go ahead and add a bit of info to the |
It's |
@le0nik: whatever the code says :) can you file a PR to fix the docs? |
@markerikson done #269 |
I believe this should cover most of the "usage with TS" stuff (including the changes from #262).
But writing docs is not my strong suit, so I'm looking for feedback :)
Closes #264