Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitbook to use version 3.2.1 #1997

Merged
merged 1 commit into from
Sep 28, 2016
Merged

Update gitbook to use version 3.2.1 #1997

merged 1 commit into from
Sep 28, 2016

Conversation

SamyPesse
Copy link
Contributor

Following my answer to #1982, this PR updates GitBook with a fix for anchor links on Firefox.

the URL is retained correctly (Chrome and Firefox), but there still some weird positioning on Firefox, I'll make another PR once we fix this issue as well.

@timdorr
Copy link
Member

timdorr commented Sep 28, 2016

Is this built-in now? I have that anchorjs plugin to make them work, but if it's not needed anymore, we should drop it.

@SamyPesse
Copy link
Contributor Author

@timdorr No, the anchorjs adds the anchor icon next to the heading (it will be built in in GitBook v4 or maintained as an official plugin once we complete the switch to React).

This GitBook updates fixes a bug on Firefox when clicking a link containing a hash (#1982).

@timdorr
Copy link
Member

timdorr commented Sep 28, 2016

Cool. I'll merge this in, as we need to do a rebuild for the new reducer docs anyways.

@timdorr timdorr merged commit f2d485d into reduxjs:master Sep 28, 2016
@SamyPesse
Copy link
Contributor Author

This is why I believe you should host the documentation on GitBook.com:

Here is a demo setup in 5 min by selecting GitHub while creating a book:

screen shot 2016-09-28 at 15 50 51

@timdorr
Copy link
Member

timdorr commented Sep 28, 2016

Cool, we very well may do that. Would it be possible to set up a @Redux org? I already have an account if you need someone to put into the initial set of users.

@markerikson
Copy link
Contributor

@SamyPesse : As a related question: any idea why the current outlining is producing "1.1, 1.2, 1.3", instead of "1, 2, 3"? Would love to get that tweaked.

seantcoyote pushed a commit to seantcoyote/redux that referenced this pull request Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants