Add Dockerfile for discussion #11
Conversation
jtoar
force-pushed
the
ds-docker/aggregate-learnings
branch
from
22ff15f to
112607e
Compare
| RUN --mount=type=cache,target=/root/.yarn/berry/cache \ | ||
| --mount=type=cache,target=/root/.cache \ | ||
| yarn workspaces focus api | ||
| # -> why add deps after installing? |
There was a problem hiding this comment.
the @redwoodjs/internal is missing in the api/package.json so 'yarn workspaces focus api' doesn't resolve the nested dependencies of @redwoodjs/core which is 'out of focus' in the root dir.
or dependending how you look at it. the dependency is missing in the @redwoodjs/api-server.
https://github.com/redwoodjs/redwood/blob/main/packages/api-server/package.json
https://github.com/redwoodjs/redwood/blob/main/packages/api-server/src/plugins/lambdaLoader.ts
installing the api-server is definitely not necessary because it's already listed as a dependency in the api/package.json.
There was a problem hiding this comment.
Thanks @xmaxcooking! It seems like a bug on the framework's side if @redwoodjs/api-server doesn't pull in @redwoodjs/internal if it actually needs it. Let me see why it needs it and what I can do, because I'd love to avoid pulling internal in here if we can, it's one of the framework's biggest packages.
There was a problem hiding this comment.
yes. the image without it is ~100MB lighter. revisiting this should be worth the effort.
There was a problem hiding this comment.
@xmaxcooking this should let us remove the need to install it here redwoodjs/redwood#8455
There was a problem hiding this comment.
#10 would also solve this in a much better way, but it's still experimental so we may as well pursue both avenues to reduce size
There was a problem hiding this comment.
redwoodjs/redwood#8455 just landed in v5.2.4, so should be possible to try out and see the difference in final image size
I want to use this Dockerfile as a resource for today's discussion. It represents my aggregate learnings from this working group and community.