fix(context): Re-export context from graphql-server
#10117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
approved these changes
Mar 6, 2024
|
@Josh-Walker-GM some of the checks aren't running (milestone, label, etc), but if you could add a changelog entry i'll merge when everything else passes |
|
Thanks @jtoar! I'd been hoping the changelog would fail so I could give it my first go - it's been a bit since I committed to the redwood repo itself. Funny about the check statuses! They must have run because the GitHub mobile app shows them as having run and then the changelog one failed. It seems like it's just something on the presentation side at GitHub and not the job running itself. Cool haha |
jtoar
pushed a commit
that referenced
this pull request
Mar 6, 2024
**Problem** As part of v7 context refactoring we move context from `@redwoodjs/graphql-server` to `@redwoodjs/context`. We had a period of time where both locations had the code with the `graphql-server` variant being deprecated. However, once it was removed from `graphql-server` this was a breaking change as any user who had specifically imported from `graphql-server` would now have tp update their code. This reverts this and allows them to continue to import from the `graphql-server` package. **Changes** 1. Re-export the `context` and `setContext` from the package as was done previous to v7.
jtoar
pushed a commit
that referenced
this pull request
Mar 6, 2024
**Problem** As part of v7 context refactoring we move context from `@redwoodjs/graphql-server` to `@redwoodjs/context`. We had a period of time where both locations had the code with the `graphql-server` variant being deprecated. However, once it was removed from `graphql-server` this was a breaking change as any user who had specifically imported from `graphql-server` would now have tp update their code. This reverts this and allows them to continue to import from the `graphql-server` package. **Changes** 1. Re-export the `context` and `setContext` from the package as was done previous to v7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As part of v7 context refactoring we move context from
@redwoodjs/graphql-serverto@redwoodjs/context. We had a period of time where both locations had the code with thegraphql-servervariant being deprecated. However, once it was removed fromgraphql-serverthis was a breaking change as any user who had specifically imported fromgraphql-serverwould now have tp update their code. This reverts this and allows them to continue to import from thegraphql-serverpackage.Changes
contextandsetContextfrom the package as was done previous to v7.