feat(og-gen): Adds package and vite plugin for dynamic og generation #10439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
commented
Apr 11, 2024
| const updatedConfig = plugin.config() | ||
|
|
||
| // Assert the rollup inputs | ||
| expect(updatedConfig.build?.rollupOptions?.input).toEqual({ |
There was a problem hiding this comment.
We'll go through this again @cannikin when we pair, so can change things, but just a headsup here on what the output paths will look like
dac09
commented
Apr 11, 2024
… into feat/og-gen-mw-vite-plugin * 'feat/og-gen-mw-vite-plugin' of github.com:dac09/redwood: Update rbac.md - code match (redwoodjs#10405) chore: make crwa e2e test work across branches (redwoodjs#10437) feat: [Auth] Common AuthProvider & use* changes for middleware auth (redwoodjs#10420)
dac09
commented
Apr 11, 2024
packages/og-gen/package.json
Outdated
| { | ||
| "name": "@redwoodjs/og-gen", | ||
| "version": "7.0.0", | ||
| "type": "module", |
dac09
commented
Apr 11, 2024
packages/og-gen/tsconfig.json
Outdated
| "compilerOptions": { | ||
| "rootDir": "src", | ||
| "outDir": "dist", | ||
| "moduleResolution": "Node16", // uses the exports field in @redwoodjs/vite, @redwoodjs/internal |
cannikin
approved these changes
Apr 11, 2024
… into feat/og-gen-mw-vite-plugin * 'feat/og-gen-mw-vite-plugin' of github.com:dac09/redwood: chore(deps): bump browserify-sign from 4.2.1 to 4.2.3 (redwoodjs#10446) chore(deps): bump tar from 6.1.11 to 6.2.1 in /docs (redwoodjs#10438) chore(deps): update dependency firebase to v10.11.0 (redwoodjs#10366) fix(auth): Handle when authorization header is lowercased (redwoodjs#10442)
dac09
added a commit
that referenced
this pull request
Apr 12, 2024
…g-gen-mw-p2 * 'main' of github.com:redwoodjs/redwood: feat(og-gen): Adds package and vite plugin for dynamic og generation (#10439) chore(deps): bump browserify-sign from 4.2.1 to 4.2.3 (#10446) chore(deps): bump tar from 6.1.11 to 6.2.1 in /docs (#10438) chore(deps): update dependency firebase to v10.11.0 (#10366) fix(auth): Handle when authorization header is lowercased (#10442) Update rbac.md - code match (#10405) chore: make crwa e2e test work across branches (#10437) feat: [Auth] Common AuthProvider & use* changes for middleware auth (#10420)
dac09
added a commit
that referenced
this pull request
Apr 16, 2024
…-dbauth-middleware * 'main' of github.com:redwoodjs/redwood: chore(location): Accept URL-like object (#10467) fix(router): Remove barrel exports from router.tsx (#10464) chore(dbauth-mw): Refactor web side dbAuth creation (#10460) chore(router): Prevent circular dependency for namedRoutes (#10463) chore(router): route-validators: Better types and clean up comments (#10462) feat(server-auth): dbAuth 3/3 - handle login, logout, signup, etc. requests if forwarded from middleware (#10457) docs(router): Document new NavLink className replacement behavior (#10401) chore(refactor): Split the router out into smaller logical units (#10434) feat(server-auth): Part 1/3: dbAuth middleware support (web side changes) (#10444) chore(auth): Build: Put ESM at the root, and CJS in /cjs (#10458) fix(ssr): Successfully serve static assets like `favicon.png` (#10455) chore(deps): update chore (#10367) (docs) Fix useCache headers and links (#10451) chore: remove aws-lambda (#10450) chore(deps): update dependency typescript to v5.4.5 (#10452) feat(og-gen): Update implementation of useLocation | Update App template (#10441) feat(og-gen): Adds package and vite plugin for dynamic og generation (#10439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10440
This PR creates a new package
@redwoodjs/ogimage-gen- that we'll use to house the dynamic OG image generator using middleware.The PR is broken down into a smaller chunk, and includes the package setup, and the vite plugin we will need for the middleware to work!
Related/Oustanding:
useLocationhookNaming 🐥
I'm not tied to the name of the package, and happy to take suggestions here please! The package will house middleware, react hooks and this vite plugin