Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include .storybook folder in Linting #11748

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Include .storybook folder in Linting #11748

merged 6 commits into from
Dec 9, 2024

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Dec 5, 2024

From the ESLint docs:

ESLint always follows a couple of implicit ignore rules even if the --no-ignore flag is passed. The implicit rules are as follows:

node_modules/ is ignored.
dot-files (except for .eslintrc.*) as well as dot-folders and their contents are ignored.

Since the upgrade to storybook-vite (which now has the config files in web/.storybook) its config files have become a blind spot for ESLint … this PR fixes that.

Hence this should also become part of the next patch release as v8 introduced it.

From the [ESLint docs](https://eslint.org/docs/latest/use/configure/ignore-deprecated):

> ESLint always follows a couple of implicit ignore rules even if the --no-ignore flag is passed. The implicit rules are as follows:
> 
>    node_modules/ is ignored.
>    dot-files (except for .eslintrc.*) as well as dot-folders and their contents are ignored.
@Tobbe Tobbe added the release:fix This PR is a fix label Dec 9, 2024
@Tobbe Tobbe added this to the next-release-patch milestone Dec 9, 2024
@Tobbe Tobbe enabled auto-merge (squash) December 9, 2024 11:29
@Tobbe Tobbe merged commit 776403f into redwoodjs:main Dec 9, 2024
50 checks passed
Tobbe added a commit that referenced this pull request Dec 25, 2024
@Tobbe Tobbe modified the milestones: next-release-patch, v8.4.2 Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants