Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] cypress storybook build failure example #3511

Conversation

virtuoushub
Copy link
Collaborator

example branch to illustrate how #3509 surfaces potential build errors.

see also: #3508 / #3509

@thedavidprice thedavidprice marked this pull request as ready for review October 5, 2021 17:30
@thedavidprice thedavidprice marked this pull request as draft October 5, 2021 17:30
@virtuoushub
Copy link
Collaborator Author

virtuoushub commented Oct 5, 2021

Sorry if I was not clear, running this against 13c8071 is not a valid test; in order for this to verify my suspicions we want to run e2e against c6cc8bb

[edit] I just pushed up a revert commit in 5e9a8bc, hopefully that auto triggers the Storybook e2e and we can prove/disprove my hypothesis.

@virtuoushub virtuoushub force-pushed the feat/cypress-storybook-build-failure-example branch 3 times, most recently from 0ce4cdd to f8f6e03 Compare October 6, 2021 00:50
@virtuoushub
Copy link
Collaborator Author

closing as I seem to be running into some sort of caching issue where I can no longer get the CI to download dependencies in the state they were in https://github.com/redwoodjs/redwood/runs/3779605361?check_suite_focus=true; which means I cannot easily reproduce the observed Storybook build failure.

I am 99% confident in #3509 at this point so I think it is safe to keep it as is and if I notice a similar build failure surfaced by the stderr that I saw locally, I'll call it out in a subsequent ticket w/ steps to reproduce.

@virtuoushub virtuoushub closed this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant