-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade ESLint from v7 to v8 #3725
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
346b5bf
chore(eslint-config): Bump eslint to 8 and jsx-a11y plugin to match.
nzdjb c9bfe7e
chore(eslint-config): Missing bumps from previous commit.
nzdjb 12f270f
chore(eslint-config): Bump react plugin to support eslint 8.
nzdjb 7f9439d
style(router): Add types for onClick.
nzdjb d8ea420
fix(internal): Resolve unsafe chaining by using empty array if errors…
nzdjb a55300b
fix(router): Better typing for onClick on links.
nzdjb aff0e92
style: Remove field omission that was causing unclear typing.
nzdjb bd2090d
style: Add missing id type.
nzdjb 3ded8fd
chore(es-config): Resolve constraints issue.
nzdjb dfaaab2
chore(deps): Yarn dedupe.
nzdjb 6a7b8d5
update packages
thedavidprice 37ec6cb
Merge branch 'main' into pr/3725
thedavidprice 8d66b40
update yarn.lock
thedavidprice e962067
Merge branch 'main' into main
thedavidprice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,7 +45,7 @@ export const generateGraphQLSchema = async () => { | |
// This tries to clean up the output of those errors. | ||
console.error(e) | ||
console.error(chalk.red('Error parsing SDLs or Schema')) | ||
for (const error of e?.errors) { | ||
for (const error of e.errors ?? []) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice! |
||
console.error(error.details) | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtoar can you confirm this is correct?