Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netlify ignore build script #5518

Merged
merged 2 commits into from
May 12, 2022
Merged

Fix netlify ignore build script #5518

merged 2 commits into from
May 12, 2022

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented May 12, 2022

Once PRs with doc-related changes are merged to main, they should deploy no matter what.

The diff makes it look like there's a lot of changes, but I really just added an if else statement that checks if process.env.BRANCH is main.

I'm not sure what the value of process.env.BRANCH will actually be if the branch is main (I assume just 'main'), so I'll have to merge to find out. I'll follow up with a fix if necessary.

@jtoar jtoar added topic/docs release:fix This PR is a fix labels May 12, 2022
@jtoar jtoar self-assigned this May 12, 2022
@netlify
Copy link

netlify bot commented May 12, 2022

Deploy Preview for redwoodjs-docs ready!

Name Link
🔨 Latest commit 2f28753
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/627ccf23f8692700093c56a0
😎 Deploy Preview https://deploy-preview-5518--redwoodjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jtoar jtoar marked this pull request as ready for review May 12, 2022 09:17
@jtoar jtoar merged commit b2a2218 into main May 12, 2022
@jtoar jtoar deleted the ds-fix-netlify-ignore-build branch May 12, 2022 09:17
@jtoar jtoar modified the milestones: next-release, v1.5.0 May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

1 participant