Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify check #5746

Merged
merged 5 commits into from
Jun 20, 2022
Merged

Simplify check #5746

merged 5 commits into from
Jun 20, 2022

Conversation

andershagbard
Copy link
Contributor

!== can only return a boolean value, so no need to explicitly return true or false.

@netlify
Copy link

netlify bot commented Jun 11, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 5f273ac
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62b0841abdd5b6000889d18e

@dthyresson dthyresson requested a review from cannikin June 14, 2022 19:45
Copy link
Member

@cannikin cannikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I'm usually pretty good about avoiding stuff like that!

@cannikin cannikin enabled auto-merge (squash) June 14, 2022 20:46
@jtoar jtoar added the release:fix This PR is a fix label Jun 15, 2022
@cannikin cannikin merged commit eb99751 into redwoodjs:main Jun 20, 2022
@jtoar jtoar added this to the next-release milestone Jun 20, 2022
@andershagbard andershagbard deleted the simplify-check branch June 20, 2022 19:06
dac09 added a commit to dac09/redwood that referenced this pull request Jun 20, 2022
…ctmode-gen

* 'main' of github.com:redwoodjs/redwood: (24 commits)
  fix: enable `windowsHide` for Windows OSes (redwoodjs#5734)
  Simplify check (redwoodjs#5746)
  Version docs to 2.0
  Update all contributors
  v2.0.0
  fix(deps): update graphqlcodegenerator monorepo (redwoodjs#5772)
  fix(deps): update storybook monorepo to v6.5.9 (redwoodjs#5770)
  fix(deps): update dependency core-js to v3.23.1 (redwoodjs#5771)
  fix(deps): update dependency @apollo/client to v3.6.8 (redwoodjs#5769)
  Correct a few spelling mistakes (redwoodjs#5747)
  docs: yet another set of single byte typo squashing (redwoodjs#5749)
  docs: GraphQL Yoga's playground, not Apollo Server's (redwoodjs#5741)
  docs(graphql): replaced outdated mentions to Apollo Server (redwoodjs#5768)
  Update routing-params.md (redwoodjs#5706)
  fixing typo (redwoodjs#5699)
  fix: RedwoodLogger -- Mask errors, but include stack trace in formatter (redwoodjs#5704)
  Lint fix some template files (redwoodjs#5766)
  fix: RedwoodLogger -- Mask errors, but include stack trace in formatter (redwoodjs#5704)
  Lint fix some template files (redwoodjs#5766)
  docs: adding precisions and fixes to contributing (redwoodjs#5760)
  ...
@jtoar jtoar modified the milestones: next-release, v2.1.0 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

3 participants