-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify check #5746
Merged
Merged
Simplify check #5746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs canceled.
|
cannikin
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, I'm usually pretty good about avoiding stuff like that!
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jun 20, 2022
…ctmode-gen * 'main' of github.com:redwoodjs/redwood: (24 commits) fix: enable `windowsHide` for Windows OSes (redwoodjs#5734) Simplify check (redwoodjs#5746) Version docs to 2.0 Update all contributors v2.0.0 fix(deps): update graphqlcodegenerator monorepo (redwoodjs#5772) fix(deps): update storybook monorepo to v6.5.9 (redwoodjs#5770) fix(deps): update dependency core-js to v3.23.1 (redwoodjs#5771) fix(deps): update dependency @apollo/client to v3.6.8 (redwoodjs#5769) Correct a few spelling mistakes (redwoodjs#5747) docs: yet another set of single byte typo squashing (redwoodjs#5749) docs: GraphQL Yoga's playground, not Apollo Server's (redwoodjs#5741) docs(graphql): replaced outdated mentions to Apollo Server (redwoodjs#5768) Update routing-params.md (redwoodjs#5706) fixing typo (redwoodjs#5699) fix: RedwoodLogger -- Mask errors, but include stack trace in formatter (redwoodjs#5704) Lint fix some template files (redwoodjs#5766) fix: RedwoodLogger -- Mask errors, but include stack trace in formatter (redwoodjs#5704) Lint fix some template files (redwoodjs#5766) docs: adding precisions and fixes to contributing (redwoodjs#5760) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!==
can only return a boolean value, so no need to explicitly return true or false.