Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awsLambdaFastify test: Hide scary looking red error text #6488

Merged
merged 4 commits into from
Oct 1, 2022

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Oct 1, 2022

When running the api-server tests this scary looking red error text is printed. The test is passing, but the error makes you think you have a failing test case even though you don't.

image

Makes console.error a noop to suppress the error message

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Oct 1, 2022
@Tobbe Tobbe requested a review from jtoar October 1, 2022 15:39
@jtoar
Copy link
Contributor

jtoar commented Oct 1, 2022

100%, I have to do a double take every time. Let's fix this. Wondering though if we should make console.error a noop only for that one test ('requestHandler returns an error status if handler throws an error'), and not all the tests in this suite?

@Tobbe
Copy link
Member Author

Tobbe commented Oct 1, 2022

Wondering though if we should make console.error a noop only for that one test ('requestHandler returns an error status if handler throws an error'), and not all the tests in this suite?

Yeah, let's do that! I updated the test file.

@jtoar jtoar merged commit e302b2e into redwoodjs:main Oct 1, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Oct 1, 2022
@Tobbe Tobbe deleted the tobbe-clean-up-scary-awslambda-testcase branch October 3, 2022 06:06
@jtoar jtoar modified the milestones: next-release, v3.2.0 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants