docs: Add mocking useLocation to docs #6791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bigbuckalex! Yeah this may be too short for a how to. Initially I thought it'd go in the Testing reference, but I know that's quite long. Let me see what others things. |
|
hmm @jtoar I think this is nice a tight. My personal feelings is that How to's don't have to be super long. That being said this could potentially go in to the testing documentation instead of a How To. I think the main thing is this info should index and ideally show up in google when you type "redwoodjs test useParams or useLocation" |
|
Agreed, it makes more sense for it to be in Testing. I moved it to the Testing Components section. |
jtoar
reviewed
Nov 4, 2022
There was a problem hiding this comment.
Thanks @bigbuckalex, just a few edits and this looks good to me!
Co-authored-by: Dominic Saadi <[email protected]>
|
Thank you @jtoar! Committed your suggestions. |
jtoar
reviewed
Nov 4, 2022
jtoar
approved these changes
Nov 4, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
* add mocking-useLocation to how-to in docs * Update mocking-useLocation.md * move mocking-useLocation to testing * Update docs/docs/testing.md Co-authored-by: Dominic Saadi <[email protected]> * Update docs/docs/testing.md Co-authored-by: Dominic Saadi <[email protected]>
jtoar
added a commit
that referenced
this pull request
Nov 4, 2022
* add mocking-useLocation to how-to in docs * Update mocking-useLocation.md * move mocking-useLocation to testing * Update docs/docs/testing.md Co-authored-by: Dominic Saadi <[email protected]> * Update docs/docs/testing.md Co-authored-by: Dominic Saadi <[email protected]>
dac09
added a commit
that referenced
this pull request
Nov 7, 2022
…aching * 'main' of github.com:redwoodjs/redwood: (21 commits) [Tutorial]: Fix Typescript code blocks inconsistency (#6801) chore: update all contributors Custom auth: Fix comment in template (#6804) fix(deps): update dependency eslint to v8.26.0 (#6785) [CRWA]: Switch to using enquirer, add engine compatibility override option (#6723) (docs): Minor Command update about Storybook (#6722) docs: Add mocking useLocation to docs (#6791) Update generated render.yaml (#6771) fix flightcontrol config template (#6789) fix: publish canary using premajor (#6794) Strip resetToken and resetTokenExpiresAt from dbAuth forgotPassword handler (#6778) Fix WebAuthn when event body is base64 encoded (like when deploying to Vercel) (#6757) fix(deps): update jest monorepo (#6787) fix(deps): update dependency react-hook-form to v7.39.1 (#6786) fix(deps): update dependency fastify to v4.9.2 (#6781) fix(deps): update dependency @apollo/client to v3.7.1 (#6780) chore: fix and rebuild test project fixture (#6775) fix: add prisma resolutions to tutorial e2e test proj (#6772) fix(deps): update prisma monorepo to v4.5.0 (#6485) Fix dbauth webauthn template (redundant type import) (#6769) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a how to page in the docs that would close(#5190)
I'm not sure if there is a better place for this or if anyone would want to add to it.