Rename create auth functions #7137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
approved these changes
Dec 13, 2022
|
I suggest you merge this. And then immediately follow up with a PR that updates the test project fixture EDIT: Or just update manually, like you did 🙂 |
dac09
added a commit
that referenced
this pull request
Dec 14, 2022
…xperimental-vite-optin * 'main' of github.com:redwoodjs/redwood: (27 commits) fix(deps): update dependency @types/node to v16.18.9 (#7140) fix(deps): update dependency vscode-languageserver-textdocument to v1.0.8 (#7132) fix: add cli-helpers as dep (#7141) remove deprecated auth providers (#7138) chore: update test project fixture dbauth packages (#7139) NavLink not highlighting when on sub pages (#6939) Rename create auth functions (#7137) Export underlying cache client with Service Cache functions (#7062) fix(deps): update dependency @simplewebauthn/browser to v6.2.2 (#7103) fix(deps): update dependency msw to v0.49.2 (#7126) chore(deps): update dependency nx to v15.3.3 (#7125) fix(deps): update docusaurus monorepo to v2.2.0 (#7116) [docs] How to test in GitHub actions (#6921) fix(deps): update typescript-eslint monorepo to v5.46.1 (#7109) Codemod to include full-name in test-project signup (#7124) Rebuild test-project fixture (#7123) feat: add CustomValidator (#7051) dbAuthClient (#7111) chore(deps): update dependency nx to v15.3.2 (#7114) chore(deps): update dependency redis to v4.5.1 (#7115) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the auth providers export a
create${provider}Authfunction from their web package. This is mostly an artifact of when they were all exported from the@redwoodjs-auth-webpackage where they had to be differentiated from each other. The api packages have already dropped provider-specific naming: they just export a generically namedauthDecoderfunction across the board. This PR renames all thecreate${provider}Authto justcreateAuth.