getDuplicateRoutes: Ignore redirects and other unnamed routes

[Tobbe]

Routes without names, like redirects and the notfound route should not be considered duplicate routes

This PR solves https://community.redwoodjs.com/t/redirect-from-splash-screen/4552. #7556 also solves that issue, but in another way. @Josh-Walker-GM, you wrote the duplicate route detection. What do you think?

---

When we've agreed on what solution to go for here I was thinking I'd add duplicate redirects detection too (two redirects from the same path) and duplicate notfound pages.

[Josh-Walker-GM]

Yeah apologies for not considering this at the time, the example routes I used to create this didn't consider these cases.

I was thinking I'd add duplicate redirects detection too (two redirects from the same path) and duplicate notfound pages

Don't see why we wouldn't want this 👍

[replay-io]

16 replays were recorded for 9af280a.

0 Failed

16 Passed

requireAuth graphql checks

locator.waitFor: Target closed
=========================== logs ===========================
waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
============================================================

• useAuth hook, auth redirects checks
• Check that tags are rendering the correct dynamic data
• Check that a specific blog post is prerendered
• Check that about is prerendered
• Check that homepage is prerendered
• Check that you can navigate from home page to specific blog post
• Waterfall prerendering (nested cells)
• RBAC: Admin user should be able to delete contacts
• RBAC: Should not be able to delete contact as non-admin user
• Smoke test with dev server
• Smoke test with rw serve
• Loads Cell mocks when Cell is nested in another story
• Loads Cell Stories
• Loads MDX Stories
• Mocks current user, and updates UI while dev server is running

View test run on Replay ↗︎

[jtoar]

I didn't review the code but I'd prefer this solution as well, I wouldn't want to have to make users name the notfound route, etc

[dac09]

Let’s go with this Tobbe! Only consideration is, can you/should you be able to navigate to the not found page programmatically?

Routes,notFound() (I.e. the name that you set) - this does not currently work, and we have no way of navigating to a 404 page (unless we do navigate('/bazingaKittensNonExistentRoute'))