Fastify server: Default to localhost

[Tobbe]

The table here is good for understanding the host options https://www.fastify.io/docs/latest/Reference/Server/#listen

I chose to just remove the option, which will use the default, which is localhost. If someone prefers to be more explicit about it, let me know and I'll add it in. (See EDIT below)

I needed this change for #8002
It will also work towards making it possible to use RW in ipv6-only environments (at least it should help, more changes might be needed in other places)

EDIT:

I decided to keep the host config, but changed it to localhost, which is the default. Right now this is a bit redundant, but at some point we'll want to make this configurable (see #6362) and then we'll need it.

[replay-io]

18 replays were recorded for 0ab07bd.

0 Failed

18 Passed

• useAuth hook, auth redirects checks
• Check that a specific blog post is prerendered
• Check that about is prerendered
• Check that homepage is prerendered
• Check that meta-tags are rendering the correct dynamic data
• Check that rehydration works for page not wrapped in Set
• Check that rehydration works for page with Cell in Set
• Check that rehydration works for page with code split chunks
• Check that you can navigate from home page to specific blog post
• Waterfall prerendering (nested cells)
• RBAC: Admin user should be able to delete contacts
• RBAC: Should not be able to delete contact as non-admin user
• Smoke test with dev server
• Smoke test with rw serve
• Loads Cell mocks when Cell is nested in another story
• Loads Cell Stories
• Loads MDX Stories
• Mocks current user, and updates UI while dev server is running

View test run on Replay ↗︎

[jtoar]

Maybe related: #6362

[Tobbe]

Merging this in alignment with discussions over at #8233 (comment)

[dennemark]

The fastify link above states some exceptions, when Not to use localhost.
Unfortunately we are now running into issues with localhost being the default. We need to set 0.0.0.0
Any way to use the redwood.toml [api] host variable instead?

When deploying to a Docker, and potentially other, containers, it is advisable to listen on 0.0.0.0 because they do not default to exposing mapped ports to localhost:

fastify.listen({ port: 3000, host: '0.0.0.0' }, (err, address) => {
  if (err) {
    fastify.log.error(err)
    process.exit(1)
  }
})

[Josh-Walker-GM]

Also sorry @Tobbe we appear to have went backwards on this work when we added the fastify ejection and updated the CLI handlers to use the new fastify package:

redwood/packages/cli/src/commands/serveHandler.js

Line 32 in 10e5341

host: process.env.NODE_ENV === 'production' ? '0.0.0.0' : '::',

This does make me wonder why then the change in this PR is causing issues? 🤔 At least for the current main branch CLI this is the case.

[steveoon]

After upgrade to 5.2.3, run yarn rw dev, and http://localhost:8911/graphql could not be accessed.

the Erroe:
web | [webpack-dev-server] [HPM] Error occurred while proxying request localhost:8910/graphql to http://localhost:8911/ [ECONNREFUSED] (https://nodejs.org/api/errors.html#errors_common_system_errors)

[Tobbe]

@steveoon Can you please post your full console output? And the output of yarn rw info.
Thank you 🙂

[jtoar]

@steveoon we reverted this change in [v5.2.3])https://github.com/redwoodjs/redwood/releases/tag/v5.2.3). There was a span of time between v5.2.0 and v5.2.3 (a few days really) where this functionality was in a stable release—did you make a change to api or web hosts in that span in redwood.toml?