-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix logFormatter when no undefined ns, name, or message. #8181
Conversation
Unable to test with |
@dthyresson what help do you need to get this one in (if anything)? |
I just need to test with rwfw . My unit tests pass. Then a review. I’ve got it in morning |
@dthyresson Roger that 👍 Was going to suggest you try testing via canary package if needed. Keep me/us posted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me ✅
Not sure if you were simply looking for another pair of eyes or had specific questions for Tobbe. Deferring to you re: next steps here.
Fix #8180.
When the log formatter encounters log statements that lack the
ns
or logname
or nomessage
attribute -- say from Fastify or Yoga debug logging, the message includes "undefined".Note that when the
graphql-server
logs, the child logger has a name, but not ans
value.The PR checks for the undefined cases when formatting the values and also adds a test to ensure that the text "undefined" does not appear in the formatted log content when ns, name or message are not provided.