-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coherence deploy): add setup deploy coherence #8234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
commented
May 5, 2023
jtoar
commented
May 16, 2023
jtoar
commented
May 16, 2023
jtoar
commented
May 16, 2023
jtoar
added a commit
that referenced
this pull request
May 17, 2023
* feat: add setup deploy coherence * add changes to yaml template * Update packages/cli/src/commands/setup/deploy/providers/coherenceHandler.js * warn on prerender, style * add warning to docs * properly escape quotes * configure toml * throw instead of warn * style: move notes inline * properly try-catch * add to intro * add note about data migrations
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 19, 2023
…te-default * 'main' of github.com:redwoodjs/redwood: (23 commits) chore(deps): update dependency @clerk/clerk-react to v4.16.2 (redwoodjs#8362) chore(package size): implement `findup-sync` in `@redwoodjs/project-config` (redwoodjs#8315) Refactor GraphQL Server and CreateYoga to Support "api serve" with Fastify Server (redwoodjs#8339) chore(deps): update dependency octokit to v2.0.15 (redwoodjs#8360) fix(coherence): correct doc links, add commas to template (redwoodjs#8351) Parse as int, fix jsdoc (redwoodjs#8357) Update forms.md (redwoodjs#8352) chore: update yarn.lock chore(release): update release command for minors chore(deps): update dependency rimraf to v5.0.1 (redwoodjs#8350) chore(deps): update dependency glob to v10.2.5 (redwoodjs#8349) feat(coherence deploy): add setup deploy coherence (redwoodjs#8234) fix(deps): update dependency listr2 to v6.6.0 (redwoodjs#8347) fix(deps): update dependency react-router-dom to v6.11.2 (redwoodjs#8345) fix(deps): update prisma monorepo to v4.14.1 (redwoodjs#8346) fix(deps): update dependency webpack to v5.83.1 (redwoodjs#8348) chore(deps): update dependency dependency-cruiser to v13 (redwoodjs#8322) chore(deps): update dependency @clerk/clerk-react to v4.16.1 (redwoodjs#8324) chore(deps): update dependency @clerk/types to v3.38.0 (redwoodjs#8325) chore(deps): update dependency nx to v16.2.1 (redwoodjs#8343) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is take-two of adding Coherence to Redwood's list of supported deploy providers.
@zach-withcoherence and I just got it working in deploy target CI. There's a few things we have to figure out, but since we've gotten it working once, re-opening this PR now to keep track of the remaining tasks:
yarn rw prisma migrate dev
?yarn rw prisma migrate deploy
? we also have to make sure seeding works as expectedadapter: postgresql
to thecoherence.yml
template if the database is postgresql.--no-prerender
is still necessary on the first deploy because the database ready. we have to handle this through docs at the moment