fix(vite): revert vite-plugin-commonjs upgrade
#8279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
changed the title
vite-plugin-commonjs
|
This probably happened because the commonjs plugin switched to ESM only (or changed their exports field) - let me double check when it was updated and what changed! |
|
@dac09 yeah something like that for sure! I Just a miss on my part as I merged the upgrade in for v5.1.0, so this is an as-of-today bug. Can't find the commit, but inspecting the dist between vite-plugin-commonjs 0.6.2 and 0.7.0, I see: 0.6.2
0.7.0
|
dac09
reviewed
May 10, 2023
This reverts commit 3c2b22b.
jtoar
changed the title
vite-plugin-commonjsvite-plugin-commonjs upgrade
jtoar
added a commit
that referenced
this pull request
May 10, 2023
* fix: import default from commonjs plugin * prefer import * style: remove comment * downgrade vite-plugin-commonjs * Revert most changes This reverts commit 3c2b22b.
jtoar
added a commit
that referenced
this pull request
May 10, 2023
* fix: import default from commonjs plugin * prefer import * style: remove comment * downgrade vite-plugin-commonjs * Revert most changes This reverts commit 3c2b22b.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://community.redwoodjs.com/t/redwood-v5-0-0-upgrade-guide/4715/23.