Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli) setup tsconfig update template path #8400

Merged
merged 2 commits into from
May 24, 2023

Conversation

thedavidprice
Copy link
Contributor

This modifies the template path of tsconfig used during yarn rw setup tsconfig from:

  • https://raw.githubusercontent.com/redwoodjs/redwood/v5.2.2/packages/create-redwood-app/template/web|api/tsconfig.json
    to
  • https://raw.githubusercontent.com/redwoodjs/redwood/v5.2.2/packages/create-redwood-app/templates/ts/web|api/tsconfig.json

This change is necessary after the CRAW template was split into separate directories.

@thedavidprice thedavidprice requested a review from jtoar May 24, 2023 00:02
@thedavidprice
Copy link
Contributor Author

@jtoar straightforward; just looking for sanity check — please merge after taking a look

Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thedavidprice!

@jtoar jtoar added release:fix This PR is a fix fixture-ok Override the test project fixture check labels May 24, 2023
@jtoar jtoar added this to the next-release-patch milestone May 24, 2023
@replay-io
Copy link

replay-io bot commented May 24, 2023

@jtoar jtoar merged commit 435fcf0 into main May 24, 2023
@jtoar jtoar deleted the dsp-fix-setup-tsconfig-rawpath branch May 24, 2023 00:27
jtoar pushed a commit that referenced this pull request May 24, 2023
@jtoar jtoar modified the milestones: next-release-patch, v5.2.3 May 24, 2023
jtoar pushed a commit that referenced this pull request May 24, 2023
@jtoar jtoar modified the milestones: v5.2.3, next-release May 24, 2023
@jtoar jtoar modified the milestones: next-release, next-release-patch, v5.2.4 Jun 2, 2023
jtoar pushed a commit that referenced this pull request Jun 2, 2023
@jtoar jtoar modified the milestones: v5.2.4, next-release, next-release-patch Jun 2, 2023
jtoar pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants