-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade Jotai to v2 and use yarn v4 #55
Open
airslice
wants to merge
10
commits into
alpha
Choose a base branch
from
chore/upgrade-some-dependency-and-use-yarn-4
base: alpha
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d833a5c
refactor: upgrade some dependency and use yarn v4
airslice 0fc6b26
chore: enable corepack
airslice f1eba96
chore: clean up
airslice 6bb665f
chore: add eslint-plugin-import as dev dependency
airslice df08e39
test: fix test
airslice bd667e5
chore: ignore .yarn
airslice 25f32bf
Merge branch 'alpha' into chore/upgrade-some-dependency-and-use-yarn-4
airslice 714b79d
refactor: updates on ui doc
airslice 8b4a077
revert wrong commit
airslice 5b304a3
Merge branch 'alpha' into chore/upgrade-some-dependency-and-use-yarn-4
airslice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,8 @@ dist | |
dist-ssr | ||
*.local | ||
|
||
.yarn | ||
|
||
# Editor directories and files | ||
.vscode/* | ||
!.vscode/extensions.json | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
nodeLinker: node-modules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,10 +54,11 @@ | |
"cesium-dnd": "1.1.0", | ||
"csv-parse": "5.5.2", | ||
"d3": "7.9.0", | ||
"escape-string-regexp": "4.0.0", | ||
"fast-xml-parser": "4.3.2", | ||
"framer-motion": "11.0.27", | ||
"geojson": "0.5.0", | ||
"jotai": "1.12.1", | ||
"jotai": "2.9.3", | ||
"js-md5": "0.7.3", | ||
"jsep": "1.3.8", | ||
"jsonpath-plus": "7.2.0", | ||
|
@@ -71,7 +72,7 @@ | |
"react-dnd-html5-backend": "16.0.1", | ||
"react-error-boundary": "4.0.11", | ||
"react-nl2br": "1.0.4", | ||
"react-use": "17.5.0", | ||
"react-use": "17.5.1", | ||
"resium": "1.18.2", | ||
"suspend-react": "0.1.3", | ||
"tailwind-merge": "2.5.2", | ||
|
@@ -80,11 +81,10 @@ | |
"tiny-invariant": "1.3.3", | ||
"use-callback-ref": "1.3.2", | ||
"use-custom-compare": "1.4.0", | ||
"uuid": "9.0.1", | ||
"uuid": "10.0.0", | ||
"xstate": "4.38.2" | ||
}, | ||
"devDependencies": { | ||
"@apollo/client": "3.8.1", | ||
"@chromatic-com/storybook": "^1.3.3", | ||
"@emotion/jest": "11.11.0", | ||
"@storybook/addon-essentials": "8.0.8", | ||
|
@@ -117,6 +117,7 @@ | |
"clsx": "2.1.1", | ||
"eslint": "8.57.0", | ||
"eslint-config-reearth": "0.3.0", | ||
"eslint-plugin-import": "2.31.0", | ||
"eslint-plugin-react-hooks": "4.6.0", | ||
"eslint-plugin-react-refresh": "0.4.6", | ||
"eslint-plugin-storybook": "0.8.0", | ||
|
@@ -135,7 +136,5 @@ | |
"vitest": "1.0.4", | ||
"web-streams-polyfill": "3.2.1" | ||
}, | ||
"resolutions": { | ||
"jackspeak": "2.1.1" | ||
} | ||
"packageManager": "[email protected]" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not follows the origin idea how it should work.
I think it's coming from the upgrade Jotai to v2 around async atom maybe.
However it seems also make sense to have this result if set data is async, but if it's by design that the orignalFeatures should be updated immediatly, we need to investigate the cause and fix it.
Also i don't understand how feature2 been removed from oringalFeatures in this test.