Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the default colorBlendMode value for 3D tiles to "highlight" #59

Merged
merged 8 commits into from
Nov 29, 2024
Merged

fix: set the default colorBlendMode value for 3D tiles to "highlight" #59

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
375c6d9
fix: set the default colorBlendMode value to "highlight"
mulengawilfred Nov 27, 2024
b512c6d
fix: add default parameter
mulengawilfred Nov 28, 2024
a8c377f
Revert "fix: add default parameter"
mulengawilfred Nov 28, 2024
81d4497
fix: add default parameter
mulengawilfred Nov 28, 2024
c33711d
fix: remove logical OR operator
mulengawilfred Nov 29, 2024
5d685b6
fix: add property for default
mulengawilfred Nov 29, 2024
565c405
fix: refactor default prop
mulengawilfred Nov 29, 2024
11b82b4
fix: remove 'default' prop
mulengawilfred Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/engines/Cesium/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,15 +546,15 @@ export const colorBlendMode = (colorBlendMode?: "highlight" | "replace" | "mix"
)[colorBlendMode || ""];

export const colorBlendModeFor3DTile = (
colorBlendMode?: "highlight" | "replace" | "mix" | "default",
colorBlendMode: "highlight" | "replace" | "mix" = "highlight",
) =>
(
({
highlight: Cesium3DTileColorBlendMode.HIGHLIGHT,
replace: Cesium3DTileColorBlendMode.REPLACE,
mix: Cesium3DTileColorBlendMode.MIX,
}) as { [key in string]?: Cesium3DTileColorBlendMode }
)[colorBlendMode || ""];
)[colorBlendMode]

export const heightReference = (
heightReference?: "none" | "clamp" | "relative",
Expand Down
Loading