Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): selection indicator not disappearing on base map click #7

Merged
merged 1 commit into from
May 13, 2024

Conversation

catpotd
Copy link
Contributor

@catpotd catpotd commented May 13, 2024

Overview

Fixes the persistent selection indicator bug on base map clicks.

CleanShot 2024-04-21 at 21 14 44

What I've done

  • Implemented a check to clear the selection when clicking on the base map.

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@catpotd
Copy link
Contributor Author

catpotd commented May 13, 2024

This PR is associated with the following:
reearth/reearth-visualizer#966

@catpotd catpotd merged commit 5caa55b into reearth:main May 13, 2024
@catpotd catpotd deleted the fix/indicator-hide-on-click branch May 13, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants