Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/show story by sdk #22

Merged
merged 15 commits into from
Jun 17, 2024
Merged

Feat/show story by sdk #22

merged 15 commits into from
Jun 17, 2024

Conversation

xeewii
Copy link
Contributor

@xeewii xeewii commented Jun 12, 2024

https://github.com/rees46/planning/issues/826

feat:

  • Добавлено открытие кампании по id

fix:

  • Добавлен отступ для текста внутри текстового блока
  • Исправлен line spacing внутри текстового блока

refactor

@xeewii xeewii self-assigned this Jun 12, 2024
@xeewii xeewii requested a review from TorinAsakura June 12, 2024 12:19
@xeewii
Copy link
Contributor Author

xeewii commented Jun 12, 2024

@gochicus
Вызов стори кампании через SDK происходит так:
sdk.showStory(STORY_ID)
где STORY_ID - это числовое (Int) айди кампании

И теперь для работы с srotires view её нужно инициализаровать через sdk.

Все изменения в README

@xeewii xeewii requested a review from TorinAsakura June 13, 2024 12:23
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Остались небольшие правки.

В своём коммите я вынес некоторые фичи работы с шрифтами и цветами в отдельный слой. Потом надо будет разделить эти утилиты ещё глубже.

@xeewii xeewii requested a review from TorinAsakura June 17, 2024 13:24
@TorinAsakura TorinAsakura merged commit b4ab7b0 into master Jun 17, 2024
1 check passed
@TorinAsakura TorinAsakura deleted the feat/show-story-by-sdk branch June 17, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants