small-user-avatars - Don't mistakenly add to commit authors
#7139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
approved these changes
Dec 4, 2023
dgw
force-pushed
the
small-user-avatars/no-commit-author
branch
from
ef8c1e8 to
7a7c2ed
Compare
`user-mention` link without a leading `@` symbol will log an error via `assertNodeContent` helper.
dgw
force-pushed
the
small-user-avatars/no-commit-author
branch
from
7a7c2ed to
50e44a7
Compare
|
Here we go. Had to learn about the difference between regular and 
Amended for you, with no linter error this time 🙂 |
fregante
changed the title
small-user-avatars - fix: ignore fake commit-author mentionssmall-user-avatars - Don't mistakenly add to commit authors
|
I think this broke the entire feature. See on https://github.com/refined-github/refined-github/releases 
The assertion error is confusing, but I think it's failing because the assertion expects a text node ( like |
|
Figured out what I did wrong! PR coming shortly with a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7137 based on #7137 (comment)
Test URLs
sopel-irc/sopel@120477f
Screenshot
Before:
After:
Verified that small-user-avatars are still added on regular mentions in comments, e.g. sopel-irc/sopel#2533 (comment)