Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on coffee-rails gem. #1976

Merged
merged 1 commit into from
Oct 14, 2012
Merged

Don't depend on coffee-rails gem. #1976

merged 1 commit into from
Oct 14, 2012

Conversation

ugisozols
Copy link
Member

Instead add it to Gemfile if it's not there when using template.
#1975

@krbullock
Copy link

Here I was just about to take a look at this, but you've already made the pull request. :) Thanks, looks good to me.

Instead add it to Gemfile if it's not there when using template.
@parndt parndt merged commit 9b4196b into master Oct 14, 2012
@parndt
Copy link
Member

parndt commented Feb 28, 2013

Doesn't Refinery have js.coffee files? How does this not break all of the javascripts with coffee?

@krbullock
Copy link

It adds it to the generated Gemfile in the :assets group. So it should still be available when needed, but now I can bundle install --without assets in my production environment and avoid an unnecessary dependency there.

@erithmetic
Copy link

It seems wrong that I should just "know" that my project needs coffeescript in order to compile assets for refinery. There should instead be a refinery-assets or refinery-js gem that depends on coffee, etc. that can go in the Gemfile's assets group.

@ugisozols
Copy link
Member Author

coffee-rails dependency was brought back in 017ca9d and will be apart of 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants