Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #2366 #2368

Merged
merged 1 commit into from
Aug 8, 2013
Merged

Fixes issue #2366 #2368

merged 1 commit into from
Aug 8, 2013

Conversation

xyz
Copy link
Contributor

@xyz xyz commented Aug 8, 2013

No description provided.

@@ -7,7 +7,7 @@
cursor: "crosshair"
connectWith: ".nested"
update: ->
$.post "/refinery/update_menu_positions", $menu.sortable("serialize",
$.post "/<%= Refinery::Core.backend_route %>/update_menu_positions", $menu.sortable("serialize",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if this is set to /refinery ? won't we get //refinery ? Or is it never set like that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In config example we have refinery without slash so this is ok.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look too and you're right.

ugisozols added a commit that referenced this pull request Aug 8, 2013
@ugisozols ugisozols merged commit cc7b0fd into refinery:2-1-stable Aug 8, 2013
ugisozols added a commit that referenced this pull request Aug 8, 2013
Conflicts:
	changelog.md
ugisozols added a commit that referenced this pull request Aug 8, 2013
@aghull
Copy link

aghull commented Jan 22, 2014

This doesn't account for mount paths other than '/'. Shouldn't this use a named path in routes the same as the similar dialog fix #1555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants