Fix rails4 asset_paths issues #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,7 +93,7 @@ | |||
| <% @resources.each do |resource| -%> | |||
| <% resource_linked = (resource.url == params[:current_link]) unless params[:current_link].blank? %> | |||
| <li<%= ' class="linked"'.html_safe if resource_linked %>> | |||
| <%= link_to "#{resource.title}.#{resource.ext}", asset_paths.compute_public_path(resource.url, ''), | |||
| <%= link_to "#{resource.title}.#{resource.ext}", resource.url, | |||
There was a problem hiding this comment.
We need to use asset_path(resource.url) so that it can generate proper link in case config.action_controller.asset_host is set and I'm pretty sure asset_paths.compute_public_path was used for the same reason.
Also see c2db883
There was a problem hiding this comment.
oh, does this not need to be compatible with 3.2? That would make it easy.
ugisozols
added a commit
that referenced
this pull request
Sep 6, 2013
Fix rails4 asset_paths issues
|
Thanks @complistic-gaff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the pull request for #2399, Please add comments there :)