Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change warn to use rails logger #3272

Closed
wants to merge 2 commits into from
Closed

change warn to use rails logger #3272

wants to merge 2 commits into from

Conversation

yule
Copy link

@yule yule commented Dec 19, 2016

This allows backtrace_silencers to be able to ignore this error. It also behaves nicely on what is set as log level in the environment file.

Prior to this, having config.log_level = :fatal will still output this warning as it uses the kernel warn rather than the rails logging facility.

Given that refinery is designed to run in rails, this will be the case in all cases.

@yule
Copy link
Author

yule commented Dec 19, 2016

will add test....

@parndt
Copy link
Member

parndt commented Jan 12, 2017

Thank you! Great work! 👍

I've merged your work to 572fff8 and also made it possible to inject the logger, defaulting to the Rails logger in 46b5066

@parndt parndt closed this Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants