Bugfix/3340/heroku deploy #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parndt
reviewed
Feb 28, 2018
| @@ -93,6 +94,10 @@ def append_heroku_gems! | |||
| }.sub("{{production_gems}}", production_gems.join("\n ")) | |||
| end | |||
|
|
|||
| def current_ruby_version | |||
| (env_ruby_version = ENV['RUBY_VERSION']).present? ? env_ruby_version : RUBY_VERSION | |||
There was a problem hiding this comment.
for this you can use:
def current_ruby_version
ENV['RUBY_VERSION'].presence || RUBY_VERSION
endThere was a problem hiding this comment.
Your right i under use .presence, my bad! it's fixed now
In order to use current ruby version from ENV var or constant
bricesanchez
force-pushed
the
bugfix/3340/heroku-deploy
branch
from
2a05dd3 to
1b59e47
Compare
parndt
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #3340