Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some lucide icons are broken #4621

Closed
masenf opened this issue Jan 10, 2025 · 1 comment · Fixed by #4622
Closed

Some lucide icons are broken #4621

masenf opened this issue Jan 10, 2025 · 1 comment · Fixed by #4622
Assignees
@masenf

Comments

@masenf
Copy link
Collaborator

masenf commented Jan 10, 2025

Describe the bug
The following icons do not render correctly (and actually break the entire page when used)

  • grid_2x_2_check
  • grid_2x_2_x

To Reproduce

rx.hstack(
    rx.icon("grid_2x_2_check"),
    rx.icon("grid_2x_2_x"),
)

Expected behavior
All icons in reflex's internal list are renderable.

Specifics (please complete the following information):

  • Python Version: 3.12.8
  • Reflex Version: 0.6.8
  • OS:
  • Browser (Optional):
@linear Linear
Copy link

linear bot commented Jan 10, 2025

ENG-4351 Some lucide icons are broken

masenf added a commit that referenced this issue Jan 10, 2025
@masenf
[ENG-4351] Add mapping for lucide icons
615d29e 
For icon names that don't auto-translate to the correct lucide tag name,
provide manual override.

Fix #4621
@masenf masenf mentioned this issue Jan 10, 2025
Merged
@masenf masenf self-assigned this Jan 10, 2025
masenf added a commit that referenced this issue Jan 10, 2025
@masenf
[ENG-4351] Add mapping for lucide icons (#4622)
1e7a37b 
* [ENG-4351] Add mapping for lucide icons

For icon names that don't auto-translate to the correct lucide tag name,
provide manual override.

Fix #4621

* account for new mapping in unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masenf masenf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENG-4351] Add mapping for lucide icons reflex-dev/reflex
1 participant
@masenf