Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4713] Cache pages which add states when evaluating #4788

Merged
merged 6 commits into from
Feb 19, 2025

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Feb 10, 2025

allow the backend to come up without having to re-evaluate all of the pages:

  1. cache Upload.is_used
  2. cache any route which results in new state classes being defined

Still waiting on reflex-web / flexdown support to ensure frontend/backend states are aligned.

Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #4788 will not alter performance

Comparing masenf/cache-stateful-imports (5188715) with main (0a33cc3)

Summary

✅ 12 untouched benchmarks

@masenf masenf marked this pull request as ready for review February 14, 2025 18:22
@masenf masenf changed the title Cache pages which add states when evaluating [ENG-4713] Cache pages which add states when evaluating Feb 18, 2025
Copy link

linear bot commented Feb 18, 2025

@adhami3310
Copy link
Member

since we're making another directory here inside of .web, should we start the process towards .reflex?

@masenf
Copy link
Collaborator Author

masenf commented Feb 18, 2025

since we're making another directory here inside of .web, should we start the process towards .reflex?

i dont think we need to get caught up in that yet. this new directory currently only contains compile-time artifacts, so we won't run into the reloading issue because this directory wont be modified at runtime.

but yes ultimately we will need to reorganize at some point.

the other thing that i realized is missing from this PR is that we're not including this new .web/backend directory in the backend zip, so it won't really help on the hosting service as is, unless those files get included 🤔

@masenf masenf merged commit deb1f4f into main Feb 19, 2025
43 checks passed
@masenf masenf deleted the masenf/cache-stateful-imports branch February 19, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants