-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testlib] Added QuantumESPRESSO scalability test for pw.x
#3134
[testlib] Added QuantumESPRESSO scalability test for pw.x
#3134
Conversation
Hello @Crivella, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2024-03-13 10:34:31 UTC |
Can I test this patch? |
2f5aa33
to
09e47a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Crivella, the only thing I think it misses is the documentation associated to the hpctestlib. If you don't have time to write let me know. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3134 +/- ##
========================================
Coverage 86.66% 86.66%
========================================
Files 61 61
Lines 12092 12092
========================================
Hits 10480 10480
Misses 1612 1612 ☔ View full report in Codecov by Sentry. |
@victorusu Let me know if what I've added with the last 2 commits is enough. I see there is a test failing but it does not seem to be related to my changes? |
@Crivella Could you also fix the styling issues listed here?
|
bf64ad3
to
5074078
Compare
@vkarak Done! Sorry didn't realize the bot updated it's old message |
pw.x
pw.x
This PR adds a reframe reusable test for QuantumESPRESSO, aimed at testing the scaling
pw.x
executable.The parameters
ecut
andnbnd
can be tuned in order to increase the usage of either FFTW or diagonalization routines.For now the input file is baked into the source code, but it could be easily moved to a separate repo, like for the GROMACS test