This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Election workflow #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronc
reviewed
Feb 25, 2020
|
Thanks @aaronc for the feedback! 💐 |
alpe
force-pushed
the
alex/election_workflow
branch
from
1b4d5ca to
fa999b2
Compare
|
The remaining amino codec are required for integration tests using the sdk |
aaronc
suggested changes
Mar 10, 2020
alpe
force-pushed
the
alex/election_workflow
branch
from
613c53d to
914e3e4
Compare
|
Based on our discussions, merging this with the intention to move quickly and address other issues that have been raised through smaller PRs on top of this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full election workflow - end to end
I have started to implement the election workflow end-to-end to stress the design and my understanding of it. This PR does implement the happy path. Please do not consider this DONE.
The proper message handling and validations will be implemented in separate PRs.
Resolves #31
Open questions -> will be addressed separately with new PRs on top of master (see task list)
- How to model/ create custom proposal types?- How to create deterministic group account addresses-> weave.Condition- How we need to ensure that ThresholdDecisionPolicy is not modified during proposal- we are storing a version number as well- Why min/max_voting_window- replaced by timeout- How do we handle execution failures with MsgExec in the proposal. like a transfer fails due to lack of tokens? I have implemented a executor status in the proposal so that the proposal is closed.-> msgExec will fail