Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Add query/result elements #64

Draft
wants to merge 1 commit into
base: aaronc/group-querier-spec
Choose a base branch
from

Conversation

alpe
Copy link
Collaborator

@alpe alpe commented Mar 30, 2020

I have added example types for pagination in queries and results.
The problem persists that some protobuf types do not contain their identifier (for example Groups, Votes). We can wither work around this by using a wrapper type like Model in this draft or we add the IDs to the types when needed. As there are no actions on Votes me may not need an ID there.
As a workflow example of a client that we should support:

  1. give me all proposals (that can be executed)
  2. execute proposal (with id=xx)

Without an ID in the query result from step 1 the second step would be impossible...

Another inconsistency is the type mismatch in queries and messages:

  • a create group Message would return the raw key but that can not be used for queries without decoding to uint64: GroupID

Prefix and Range queries feel a bit out of place with this RPC definition. They are quite powerful for receiving/ restoring state for a client but it is ok to hide them in the backend only. We can add more RPC functions instead to cover the cases.

@alpe alpe requested a review from aaronc March 30, 2020 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant