This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added example types for pagination in queries and results.
The problem persists that some protobuf types do not contain their identifier (for example Groups, Votes). We can wither work around this by using a wrapper type like
Model
in this draft or we add the IDs to the types when needed. As there are no actions on Votes me may not need an ID there.As a workflow example of a client that we should support:
Without an ID in the query result from step 1 the second step would be impossible...
Another inconsistency is the type mismatch in queries and messages:
Prefix and Range queries feel a bit out of place with this RPC definition. They are quite powerful for receiving/ restoring state for a client but it is ok to hide them in the backend only. We can add more RPC functions instead to cover the cases.