Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regen Ledger v5.0 upgrade proposal #16

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Regen Ledger v5.0 upgrade proposal #16

merged 5 commits into from
Jan 5, 2023

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Jan 3, 2023

This pull request adds the draft proposal and long-form proposal description for the upgrade to Regen Ledger v5.0.

Block height estimate: https://www.mintscan.io/regen/blocks/8942600

@robert-zaremba
Copy link

If you migrated gov proposals, then I suggest to not make a release with Cosmos SDK 0.46.7. Wait for cosmos/cosmos-sdk#14400 being release (0.46.8).
Otherwise you risk that the new proposals won't be handled correctly by the explorers. Kepler and Mintscan confirmed to work on direct gov/v1 support, but as far as I can see they didn't finish it yet.
More context: cosmos/cosmos-sdk#14334

If you don't want to wait, then you can cherry pick it into a Cosmos SDK fork (I did it at Umee for the latest release). example

cc: @clevinson, @aaronc

@ryanchristo
Copy link
Member Author

Thanks for flagging @robert-zaremba. I've been keeping an eye on the issue. We're using a fork with amino support for gov and group added to the v0.46.7 release so maybe we should consider pulling this into our fork rather than waiting for v0.46.8.

@aaronc
Copy link
Member

aaronc commented Jan 4, 2023

Yes, pulling into our fork sounds like a good option

@robert-zaremba
Copy link

@ryanchristo then easiest is to merge (not cherry pick) e7dd5e0bdc8aabadb0d4ae13bdb143f92c1cdf4c of cosmos-sdk release/v0.46.x into Regen fork.

@ryanchristo ryanchristo requested a review from clevinson January 5, 2023 20:01
@ryanchristo ryanchristo marked this pull request as ready for review January 5, 2023 22:47
@ryanchristo ryanchristo requested a review from clevinson January 5, 2023 22:47
@clevinson clevinson merged commit 82cbf34 into main Jan 5, 2023
@ryanchristo ryanchristo deleted the ryan/v5.0-upgrade branch January 5, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants