fix(all): enforce UTC where time.Time is used (#1194)

Co-authored-by: tyler <{ID}+{username}@users.noreply.github.com>
Co-authored-by: Ryan Christoffersen <[email protected]>

x/ecocredit/core/utils.go

@@ -89,10 +89,10 @@ func FormatBatchDenom(projectId string, batchSeqNo uint64, startDate, endDate *t
 		projectId,
 
 		// Start Date as YYYYMMDD
-		startDate.Format("20060102"),
+		startDate.UTC().Format("20060102"),
 
 		// End Date as YYYYMMDD
-		endDate.Format("20060102"),
+		endDate.UTC().Format("20060102"),
 
 		// Batch sequence number padded to at least three digits
 		batchSeqNo,

x/ecocredit/server/core/create_batch.go

@@ -51,7 +51,7 @@ func (k Keeper) CreateBatch(ctx context.Context, req *core.MsgCreateBatch) (*cor
 		return nil, err
 	}
 
-	startDate, endDate := timestamppb.New(req.StartDate.UTC()), timestamppb.New(req.EndDate.UTC())
+	startDate, endDate := timestamppb.New(*req.StartDate), timestamppb.New(*req.EndDate)
 	issuanceDate := timestamppb.New(sdkCtx.BlockTime())
 	batchKey, err := k.stateStore.BatchTable().InsertReturningID(ctx, &api.Batch{
 		ProjectKey:   projectInfo.Key,

x/ecocredit/server/marketplace/msg_sell.go

@@ -51,7 +51,7 @@ func (k Keeper) Sell(ctx context.Context, req *marketplace.MsgSell) (*marketplac
 		}
 
 		// verify expiration is in the future
-		if order.Expiration != nil && !order.Expiration.After(sdkCtx.BlockTime()) {
+		if order.Expiration != nil && !order.Expiration.UTC().After(sdkCtx.BlockTime()) {
 			return nil, sdkerrors.ErrInvalidRequest.Wrapf(
 				"%s: expiration must be in the future: %s", orderIndex, order.Expiration,
 			)

x/ecocredit/server/marketplace/msg_update_sell_orders.go

@@ -89,6 +89,10 @@ func (k Keeper) applySellOrderUpdates(ctx context.Context, updateIndex string, o
 	}
 
 	if update.NewExpiration != nil {
+		// force to UTC
+		expirationUTC := update.NewExpiration.UTC()
+		update.NewExpiration = &expirationUTC
+
 		// verify expiration is in the future
 		if !update.NewExpiration.After(sdkCtx.BlockTime()) {
 			return sdkerrors.ErrInvalidRequest.Wrapf(