Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/ecocredit): remove info suffix from queries #1090

Merged
merged 4 commits into from
May 6, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented May 5, 2022

Description

Ref: #1029

As a follow up to #1029 and to align with how we write queries elsewhere, this pull request removes the Info suffix from the queries and commands (not from the query response types, which should include the Info suffix).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1090 (c113b2d) into master (ea43f14) will decrease coverage by 6.29%.
The diff coverage is 98.00%.

@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
- Coverage   68.02%   61.72%   -6.30%     
==========================================
  Files         210      207       -3     
  Lines       20949    19063    -1886     
==========================================
- Hits        14250    11767    -2483     
- Misses       5383     6050     +667     
+ Partials     1316     1246      -70     
Flag Coverage Δ
experimental-codecov ?
stable-codecov 61.72% <98.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo requested review from technicallyty and aleem1314 and removed request for technicallyty May 5, 2022 16:02
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/ecocredit/server/testsuite/suite.go Outdated Show resolved Hide resolved
@ryanchristo ryanchristo merged commit 95a871e into master May 6, 2022
@ryanchristo ryanchristo deleted the ryan/1029-remove-info-queries branch May 6, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants