Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecocredit): add reference id to project #1094

Merged
merged 14 commits into from
May 13, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented May 6, 2022

Description

Closes: #1066


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1094 (3c14eeb) into master (5011d93) will decrease coverage by 0.21%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
- Coverage   68.45%   68.23%   -0.22%     
==========================================
  Files         211      211              
  Lines       21015    21053      +38     
==========================================
- Hits        14385    14365      -20     
- Misses       5324     5365      +41     
- Partials     1306     1323      +17     
Flag Coverage Δ
experimental-codecov 68.23% <38.46%> (-0.10%) ⬇️
stable-codecov ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 requested a review from ryanchristo May 6, 2022 14:48
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proto looks good to me.

proto/regen/ecocredit/v1/state.proto Outdated Show resolved Hide resolved
proto/regen/ecocredit/v1/tx.proto Outdated Show resolved Hide resolved
@aleem1314 aleem1314 marked this pull request as ready for review May 9, 2022 14:41
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Nice work.

@aleem1314 aleem1314 requested a review from technicallyty May 10, 2022 14:39
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving, few nits 👍🏻

x/ecocredit/core/msg_create_project_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/core/create_project.go Outdated Show resolved Hide resolved
@ryanchristo ryanchristo enabled auto-merge (squash) May 13, 2022 05:32
@ryanchristo ryanchristo merged commit 8190c36 into master May 13, 2022
@ryanchristo ryanchristo deleted the aleem/1066-project-reference-id branch May 13, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include project reference id for convenient lookups
3 participants