Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): add buy direct and cancel events #1148

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Jun 1, 2022

Description

Closes: #1142

Add events for buy direct and cancel sell order. Also update order_id to sell_order_Id in marketplace events.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #1148 (d810b50) into master (22fcf03) will increase coverage by 5.72%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
+ Coverage   64.39%   70.11%   +5.72%     
==========================================
  Files         215      218       +3     
  Lines       20498    22393    +1895     
==========================================
+ Hits        13199    15701    +2502     
+ Misses       6018     5344     -674     
- Partials     1281     1348      +67     
Flag Coverage Δ
experimental-codecov 69.94% <71.42%> (?)
stable-codecov 64.46% <71.42%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo marked this pull request as ready for review June 2, 2022 00:50
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit 18e2471 into master Jun 2, 2022
@ryanchristo ryanchristo deleted the ryan/1142-marketplace-events branch June 2, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add and emit event for cancel sell order
3 participants