refactor(x/ecocredit): burn basket fee and remove dist keeper

[ryanchristo]

Description

Closes: #1157 / Closes: #835 / Ref: #383

This pull request updates MsgCreateBasket to burn the fee rather than sending the fee to the community funding pool and as a result we no longer need the distribution keeper in the ecocredit module.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #1167 (8cb4007) into master (7c6081e) will decrease coverage by 0.02%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
- Coverage   69.41%   69.39%   -0.03%     
==========================================
  Files         220      220              
  Lines       22844    22833      -11     
==========================================
- Hits        15858    15844      -14     
- Misses       5614     5616       +2     
- Partials     1372     1373       +1     

Flag	Coverage Δ
experimental-codecov	69.41% <84.61%> (-0.06%)	⬇️
stable-codecov	63.77% <84.61%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[aleem1314]

lgtm

[technicallyty]

looks good! was curious about the fee handling here vs in CreateClass. seems like if we do keep this multi-fee structure, we'd want to just satisfy one fee, and not have to satisfy all?

should we address this in another PR/Issue?

[ryanchristo]

looks good! was curious about the fee handling here vs in CreateClass. seems like if we do keep this multi-fee structure, we'd want to just satisfy one fee, and not have to satisfy all?

should we address this in another PR/Issue?

Yea, I'm leaning towards satisfying one fee as well. I opened a separate issue #1165 for fee requirements.

[technicallyty]

lgtm 👍🏻