Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): query all projects with pagination #1178

Merged
merged 6 commits into from
Jun 13, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Jun 10, 2022

Description

Ref: #1137

The pull request adds a query for all projects regardless of credit class with pagination.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo
Copy link
Member Author

Pending #1168

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1178 (421ee9f) into master (b90aa21) will increase coverage by 0.14%.
The diff coverage is 94.50%.

@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
+ Coverage   69.39%   69.54%   +0.14%     
==========================================
  Files         220      221       +1     
  Lines       22859    23060     +201     
==========================================
+ Hits        15864    16036     +172     
- Misses       5621     5642      +21     
- Partials     1374     1382       +8     
Flag Coverage Δ
experimental-codecov 69.62% <94.50%> (+0.16%) ⬆️
stable-codecov 64.01% <94.50%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo marked this pull request as ready for review June 11, 2022 03:55
@ryanchristo ryanchristo requested review from technicallyty and aleem1314 and removed request for technicallyty June 11, 2022 03:55
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit c874e24 into master Jun 13, 2022
@ryanchristo ryanchristo deleted the ryan/1137-query-all-projects branch June 13, 2022 18:39
@ryanchristo ryanchristo mentioned this pull request Jun 13, 2022
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants